Rework telemetry to support durable execution case#219
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anbuzin
marked this pull request as draft
July 17, 2026 05:39
anbuzin
marked this pull request as ready for review
July 17, 2026 20:34
anbuzin
force-pushed
the
durable-telemetry-2
branch
from
July 17, 2026 21:23
e62b29d to
b8d1be1
Compare
msullivan
approved these changes
Jul 21, 2026
msullivan
left a comment
msullivan
left a comment
Contributor
There was a problem hiding this comment.
Basically looks good.
I think we should meditate on the differences and similarities between Sinks and Adapters before we finalize it
|
|
||
| @dataclasses.dataclass | ||
| class RunSpanData: | ||
| class RunSpanData(pydantic.BaseModel): |
Contributor
There was a problem hiding this comment.
Let's try to put all the "generic telemetry adapter" code in a separate file from the ai-specific stuff.
That's probably best in a follow-up PR though, at this point
Review and update docstrings in span.py
anbuzin
force-pushed
the
durable-telemetry-2
branch
from
July 22, 2026 17:21
023dbd1 to
69075d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spanto pydantic so they can travel as jsonSinkthat all spans go to. default sink is the adapter registry. users can explicitly swap it out with a different sink using a context manager. in the workflow body:span.pushto send the updated version to the sink.the
async with span("foo") as spapi didn't change much, actually, it's just different under the hood. theAdapterapi hasn't changed at all.